ORC-2164: [C++] Add external-buffer support in DataBuffer lifecycle management#2617
Closed
lucasfang wants to merge 2 commits into
Closed
ORC-2164: [C++] Add external-buffer support in DataBuffer lifecycle management#2617lucasfang wants to merge 2 commits into
lucasfang wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Adds non-owning (external) buffer attachment support to DataBuffer so it can reference externally managed memory without freeing it, and adjusts lifecycle methods accordingly.
Changes:
- Introduces
ownBuffer_tracking inDataBufferand updates destructor /reserve/resizeto be ownership-aware. - Adds
DataBuffer::setData()to attach an external raw buffer (non-owning). - Adds a unit test verifying external buffer size semantics and that external memory isn’t freed on destruction.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| c++/include/orc/MemoryPool.hh | Extends DataBuffer API with ownership flag and setData() declaration. |
| c++/src/MemoryPool.cc | Implements ownership-aware lifecycle behavior and setData() logic. |
| c++/test/TestCache.cc | Adds a focused unit test for non-owning external buffers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Thanks for your contribution! Just FYI that I just fixed the Windows CI. Please rebase to avoid confusion :) |
wgtmac
approved these changes
May 11, 2026
Member
wgtmac
left a comment
wgtmac
left a comment
There was a problem hiding this comment.
Thanks for improving this! Would you mind creating a JIRA issue for this?
lucasfang
changed the title
wgtmac
approved these changes
May 12, 2026
Member
|
Thank you, @lucasfang! |
wgtmac
pushed a commit
that referenced
this pull request
May 12, 2026
…anagement ### What changes were proposed in this pull request? This PR adds non-owning buffer support to DataBuffer so it can attach externally managed memory (via setData) without taking ownership of allocation/free, updates reserve/resize/destructor paths to be ownership-aware, and adds a focused unit test to verify that non-owning buffers keep external size semantics and do not free external memory during destruction. ### Why are the changes needed? These changes are needed to safely integrate with external prebuffer cache scenarios where memory is managed outside ORC, avoiding unnecessary reallocations and preventing ownership/lifecycle mismatches. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: GPT-5.3-codex Closes #2617 from lucasfang/mempool. Authored-by: yonghao.fyh <yonghao.fyh@alibaba-inc.com> Signed-off-by: Gang Wu <ustcwg@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds non-owning buffer support to DataBuffer so it can attach externally managed memory (via setData) without taking ownership of allocation/free, updates reserve/resize/destructor paths to be ownership-aware, and adds a focused unit test to verify that non-owning buffers keep external size semantics and do not free external memory during destruction.
Why are the changes needed?
These changes are needed to safely integrate with external prebuffer cache scenarios where memory is managed outside ORC, avoiding unnecessary reallocations and preventing ownership/lifecycle mismatches.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: GPT-5.3-codex